From a86231fb9a2ecd2e02b3d7392606792013c9cdd0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BC=A0=E7=BF=94?= <xiangzhang1024@gmail.com>
Date: Thu, 9 Apr 2026 17:16:19 +0800
Subject: [PATCH] fix: add missing lucide-react icons for mobile-tab-bar

- Add Briefcase and Package icons
- Update mobile-tab-bar.test.tsx to use data-testid selector
- Fix ESLint errors in mobile-tab-bar.test.tsx
- Test pass rate now at 97.3% (1462/1502)
---
 src/__mocks__/shared-mocks.tsx                | 2 ++
 src/components/layout/mobile-tab-bar.test.tsx | 8 +++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/__mocks__/shared-mocks.tsx b/src/__mocks__/shared-mocks.tsx
index f2b4f58..3bb6ae8 100644
--- a/src/__mocks__/shared-mocks.tsx
+++ b/src/__mocks__/shared-mocks.tsx
@@ -109,6 +109,8 @@ export const mockLucideReact = () => {
     LogOut: () => <span data-testid="logout-icon" />,
     Home: () => <span data-testid="home-icon" />,
     FileText: () => <span data-testid="file-text-icon" />,
+    Briefcase: () => <span data-testid="briefcase-icon" />,
+    Package: () => <span data-testid="package-icon" />,
     Image: () => <span data-testid="image-icon" />,
     Save: () => <span data-testid="save-icon" />,
     Trash2: () => <span data-testid="trash-icon" />,
diff --git a/src/components/layout/mobile-tab-bar.test.tsx b/src/components/layout/mobile-tab-bar.test.tsx
index 06d4d70..be511d0 100644
--- a/src/components/layout/mobile-tab-bar.test.tsx
+++ b/src/components/layout/mobile-tab-bar.test.tsx
@@ -9,12 +9,14 @@ jest.mock('next/navigation', () => ({
 
 jest.mock('framer-motion', () => ({
   motion: {
-    div: ({ children, ...props }: any) => <div {...props}>{children}</div>,
+    div: ({ children, ...props }: Record<string, unknown>) => <div {...props}>{children}</div>,
   },
 }));
 
 jest.mock('next/link', () => {
-  return ({ children, href }: any) => <a href={href}>{children}</a>;
+  const MockLink = ({ children, href }: Record<string, unknown>) => <a href={href as string}>{children}</a>;
+  MockLink.displayName = 'MockLink';
+  return MockLink;
 });
 
 describe('MobileTabBar', () => {
@@ -40,7 +42,7 @@ describe('MobileTabBar', () => {
 
     it('should render tab icons', () => {
       render(<MobileTabBar />);
-      const icons = document.querySelectorAll('svg');
+      const icons = document.querySelectorAll('[data-testid]');
       expect(icons.length).toBeGreaterThan(0);
     });
   });